Skip to content

Fix UB in sorting results with the cubic root finder#1417

Merged
mborland merged 1 commit into
developfrom
mac_roots
Jul 1, 2026
Merged

Fix UB in sorting results with the cubic root finder#1417
mborland merged 1 commit into
developfrom
mac_roots

Conversation

@mborland

@mborland mborland commented Jul 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.39%. Comparing base (188cccc) to head (e06a6a6).

Files with missing lines Patch % Lines
include/boost/math/tools/cubic_roots.hpp 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1417      +/-   ##
===========================================
- Coverage    95.40%   95.39%   -0.01%     
===========================================
  Files          827      827              
  Lines        68921    68927       +6     
===========================================
+ Hits         65752    65756       +4     
- Misses        3169     3171       +2     
Files with missing lines Coverage Δ
include/boost/math/tools/cubic_roots.hpp 87.64% <87.50%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188cccc...e06a6a6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland

mborland commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Gets our build back to green as hoped

@mborland mborland merged commit 600627d into develop Jul 1, 2026
74 of 75 checks passed
@mborland mborland deleted the mac_roots branch July 1, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant